-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instagram viewStories #105
Conversation
- viewStories prototype - instagram navigation botactions - instagram save your login info UX botactions - elementExistsInDocument & textExistsInDocument helpers - elementExists, textExists botactions - edge case for no element found in $ botaction #102
- needed wait 1s after clicking 1st story in top menu
- undefined edge case will not attempt to parse undefine but return undefined
returns empty array anyway
- used in tandem in a pipe to delete cookies for urls associated with a browser page - this in replace of deleteAllCookiesForCurrentUrl BotAction - instagram logout but for a clean logout, need to clear indexeddb too
- wip deleteIndexedDB by database name
considering async events that can fail in accomplishing the task, but not break the code like interacting with IndexedDB in a deletion call by blockage it would be nice to pass the signal through in some kind of uniform way like |
- edge-case behavior modified -> originally threw error, now returns undefined
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 38 +2
Lines 685 668 -17
Branches 172 164 -8
=========================================
- Hits 685 668 -17
Continue to review full report at Codecov.
|
- these two are covered by the e2e tests added in the last commit
- ignore serialized code injected into puppeteer, covered by e2e
- run assembled botactions if a virtual dice with X sides rolls a 1 - number of sides X is set via HO param, default is 1 - number to roll can be set via 2nd HO param, default is 1 - rollDice() helper function
another approach to randomizing BotActions #83 pipe(calculateDiceRoll(5))(
pipeCase(pipeValue => pipeValue === 1)(
// ...actions
)
) |
- added edge-case for dice with zero or negative number of sides which on roll, returns 0
- rollDice() has probability limitation of no probabilities greater than 50% therefore need another botaction - consolidate rollDice()() and probably()() ?
exploring new BotAction group: Random
related #83 (comment) |
maybe migrate the implementation https://travis-ci.com/account/migrate |
|
Issue has been resolved with Support at TravisCI. Thank you TravisCI!!!! Long live open-source. |
|
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
BotAction to viewStories and include botactions to close disruptive UX.
Related
Checklist
instagram
core
Documentation
Publishing